RE: [EXT] Re: [PATCH] devicetree: property-units: Add kohms unit

From: Biwen Li
Date: Tue Sep 17 2019 - 04:26:01 EST


>
> Caution: EXT Email
>
> Hi Biwen,
>
> On Tue, Sep 17, 2019 at 10:09 AM Biwen Li <biwen.li@xxxxxxx> wrote:
> > The patch adds kohms unit
> >
> > Signed-off-by: Biwen Li <biwen.li@xxxxxxx>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/property-units.txt
> > +++ b/Documentation/devicetree/bindings/property-units.txt
> > @@ -27,6 +27,7 @@ Electricity
> > -microamp : microampere
> > -microamp-hours : microampere hour
> > -ohms : ohm
> > +-kohms : kiloohm
> > -micro-ohms : microohm
> > -microwatt-hours: microwatt hour
> > -microvolt : microvolt
>
> What's your rationale for adding "kohms"?
> Do you need to specify resistance values that do not fit in 32-bit, and thus
32-bit is enough, I have three values, 60 kohm, 100 kohm and 500 kohm
> cannot be specified using "ohms"?
If replace with ohms, the value is as follows:
60000 ohm, 100000 ohm, 500000 ohm.
It's so long for everyone.

>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But when
> I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds