Re: [PATCH] locking: locktorture: Do not include rwlock.h directly

From: Paul E. McKenney
Date: Tue Sep 17 2019 - 13:06:26 EST


On Tue, Sep 17, 2019 at 12:16:14AM -0700, Davidlohr Bueso wrote:
> On Mon, 16 Sep 2019, Sebastian Andrzej Siewior wrote:
>
> > From: Wolfgang M. Reimer <linuxball@xxxxxxxxx>
> >
> > Including rwlock.h directly will cause kernel builds to fail
> > if CONFIG_PREEMPT_RT is defined. The correct header file
> > (rwlock_rt.h OR rwlock.h) will be included by spinlock.h which
> > is included by locktorture.c anyway.
> >
> > Remove the include of linux/rwlock.h.
> >
>
> Acked-by: Davidlohr Bueso <dbueso@xxxxxxx>

Applied, thank you!

But does anyone actually run locktorture?

Thanx, Paul

> > Signed-off-by: Wolfgang M. Reimer <linuxball@xxxxxxxxx>
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> > ---
> > kernel/locking/locktorture.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
> > index c513031cd7e33..9fb042d610d23 100644
> > --- a/kernel/locking/locktorture.c
> > +++ b/kernel/locking/locktorture.c
> > @@ -16,7 +16,6 @@
> > #include <linux/kthread.h>
> > #include <linux/sched/rt.h>
> > #include <linux/spinlock.h>
> > -#include <linux/rwlock.h>
> > #include <linux/mutex.h>
> > #include <linux/rwsem.h>
> > #include <linux/smp.h>
> > --
> > 2.23.0
> >