Re: [GIT PULL] LED updates for 5.4-rc1

From: Linus Torvalds
Date: Tue Sep 17 2019 - 21:41:20 EST


On Tue, Sep 17, 2019 at 6:14 PM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Famous last words. I now get a new warning:
>
> drivers/i2c/i2c-core-acpi.c:347:12: warning:
> âi2c_acpi_find_match_adapterâ defined but not used [-Wunused-function]

Commit 00500147cbd3 ("drivers: Introduce device lookup variants by
ACPI_COMPANION device") removed the use of that matching function, but
didn't remove the function.

It also removed the use of i2c_acpi_find_match_device(), but in that
case it _did_ remove the function.

And apparently nobody bothers checking warnings. Tssk tssk.

Linus