Re: [PATCH net] iwlwifi: add dependency of THERMAL with IWLMVM

From: Kalle Valo
Date: Wed Sep 18 2019 - 09:08:59 EST


Mao Wenan <maowenan@xxxxxxxxxx> writes:

> If CONFIG_IWLMVM=y, CONFIG_THERMAL=n, below error can be found:
> drivers/net/wireless/intel/iwlwifi/mvm/fw.o: In function `iwl_mvm_up':
> fw.c:(.text+0x2c26): undefined reference to `iwl_mvm_send_temp_report_ths_cmd'
> make: *** [vmlinux] Error 1
>
> After commit 242d9c8b9a93 ("iwlwifi: mvm: use FW thermal
> monitoring regardless of CONFIG_THERMAL"), iwl_mvm_up()
> calls iwl_mvm_send_temp_report_ths_cmd(), but this function
> is under CONFIG_THERMAL, which is depended on CONFIG_THERMAL.
>
> Fixes: 242d9c8b9a93 ("iwlwifi: mvm: use FW thermal monitoring regardless of CONFIG_THERMAL")
> Signed-off-by: Mao Wenan <maowenan@xxxxxxxxxx>

Luca, should I apply this directly to wireless-drivers?

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches