Re: [PATCH -next] PCI: tegra: Add missing include file

[Vidya Sagar]

On 9/20/2019 7:18 AM, YueHaibing wrote:
> Fix build error without CONFIG_PINCTRL
>
> drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp:
> drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function pinctrl_pm_select_default_state;
>   did you mean prandom_seed_full_state? [-Werror=implicit-function-declaration]
>    ret = pinctrl_pm_select_default_state(dev);
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          prandom_seed_full_state
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
>   drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 09ed8e4..b219d3b2 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -28,6 +28,7 @@
>   #include <linux/reset.h>
>   #include <linux/resource.h>
>   #include <linux/types.h>
> +#include <linux/pinctrl/consumer.h>
>   #include "pcie-designware.h"
>   #include <soc/tegra/bpmp.h>
>   #include <soc/tegra/bpmp-abi.h>

Thanks for pushing this change.

Reviewed-by: Vidya Sagar <vidyas@xxxxxxxxxx>