Re: [PATCH 30/32] tools lib bpf: Renaming pr_warning to pr_warn

From: Andrii Nakryiko
Date: Sun Sep 22 2019 - 17:07:43 EST


On Fri, Sep 20, 2019 at 10:06 AM Kefeng Wang <wangkefeng.wang@xxxxxxxxxx> wrote:
>
> For kernel logging macro, pr_warning is completely removed and
> replaced by pr_warn, using pr_warn in tools lib bpf for symmetry
> to kernel logging macro, then we could drop pr_warning in the
> whole linux code.
>
> Cc: Alexei Starovoitov <ast@xxxxxxxxxx>
> Cc: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
> Cc: Martin KaFai Lau <kafai@xxxxxx>
> Cc: Song Liu <songliubraving@xxxxxx>
> Cc: Yonghong Song <yhs@xxxxxx>
> Cc: bpf@xxxxxxxxxxxxxxx
> Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
> ---
> tools/lib/bpf/btf.c | 56 +--
> tools/lib/bpf/btf_dump.c | 20 +-
> tools/lib/bpf/libbpf.c | 652 ++++++++++++++++----------------
> tools/lib/bpf/libbpf_internal.h | 2 +-
> tools/lib/bpf/xsk.c | 4 +-
> 5 files changed, 363 insertions(+), 371 deletions(-)
>

Thanks! This will allow to get rid of tons warnings from checkpatch.pl.

Alexei, Daniel, can we take this through bpf-next tree once it's open?

Acked-by: Andrii Nakryiko <andriin@xxxxxx>

[...]