Re: [PATCH 5/5] arm64: dts: imx8mq: add DCSS node

From: Fabio Estevam
Date: Mon Sep 23 2019 - 12:12:43 EST


Hi Laurentiu,

On Mon, Sep 23, 2019 at 11:14 AM Laurentiu Palcu
<laurentiu.palcu@xxxxxxx> wrote:

> +
> + dcss: dcss@0x32e00000 {

Node names should be generic, so:

dcss: display-controller@32e00000

> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "nxp,imx8mq-dcss";
> + reg = <0x32e00000 0x2D000>, <0x32e2f000 0x1000>;

0x2d000 for consistency.

> + interrupts = <6>, <8>, <9>;

The interrupts are passed in the <GIC_SPI xxx IRQ_TYPE_LEVEL_HIGH> format.