Re: [PATCH 4/4] dmaengine: Add debugfs entries for PTDMA information

[gregkh@xxxxxxxxxxxxxxxxxxx]

On Tue, Sep 24, 2019 at 07:33:02AM +0000, Mehta, Sanju wrote:
> +static const struct file_operations pt_debugfs_info_ops = {
> +	.owner = THIS_MODULE,
> +	.open = simple_open,
> +	.read = ptdma_debugfs_info_read,
> +	.write = NULL,
> +};
> +
> +static const struct file_operations pt_debugfs_queue_ops = {
> +	.owner = THIS_MODULE,
> +	.open = simple_open,
> +	.read = ptdma_debugfs_queue_read,
> +	.write = ptdma_debugfs_queue_write,
> +};
> +
> +static const struct file_operations pt_debugfs_stats_ops = {
> +	.owner = THIS_MODULE,
> +	.open = simple_open,
> +	.read = ptdma_debugfs_stats_read,
> +	.write = ptdma_debugfs_stats_write,
> +};

Can you use DEFINE_SIMPLE_ATTRIBUTE() here intead of these?

thanks,

greg k-h