Re: [PATCH v2 0/2] Optimise io_uring completion waiting

From: Jens Axboe
Date: Tue Sep 24 2019 - 06:34:27 EST


On 9/24/19 4:13 AM, Jens Axboe wrote:
> On 9/24/19 3:49 AM, Peter Zijlstra wrote:
>> On Tue, Sep 24, 2019 at 10:36:28AM +0200, Jens Axboe wrote:
>>
>>> +struct io_wait_queue {
>>> + struct wait_queue_entry wq;
>>> + struct io_ring_ctx *ctx;
>>> + struct task_struct *task;
>>
>> wq.private is where the normal waitqueue stores the task pointer.
>>
>> (I'm going to rename that)
>
> If you do that, then we can just base the io_uring parts on that.

Just took a quick look at it, and ran into block/kyber-iosched.c that
actually uses the private pointer for something that isn't a task
struct...

--
Jens Axboe