Re: [RFC PATCH for 5.4 0/7] Membarrier fixes and cleanups

From: Peter Zijlstra
Date: Wed Sep 25 2019 - 04:09:06 EST


On Mon, Sep 23, 2019 at 10:55:32AM -0400, Mathieu Desnoyers wrote:
> ----- On Sep 23, 2019, at 5:06 AM, Peter Zijlstra peterz@xxxxxxxxxxxxx wrote:
>
> > On Thu, Sep 19, 2019 at 01:36:58PM -0400, Mathieu Desnoyers wrote:
> >> Hi,
> >>
> >> Those series of fixes and cleanups are initially motivated by the report
> >> of race in membarrier, which can load p->mm->membarrier_state after mm
> >> has been freed (use-after-free).
> >>
> >
> > The lot looks good to me; what do you want done with them (them being
> > RFC and all) ?
>
> I can either re-send them without the RFC tag, or you can pick them directly
> through the scheduler tree.

I've picked them up (and fixed them up, they didn't apply to tip) and
merge them with Eric's task_rcu_dereference() patches.

I'll push it out in a bit.