Re: [PATCH v3 04/10] sched/fair: rework load_balance

From: Vincent Guittot
Date: Mon Sep 30 2019 - 03:45:02 EST


On Mon, 30 Sep 2019 at 03:13, Rik van Riel <riel@xxxxxxxxxxx> wrote:
>
> On Thu, 2019-09-19 at 09:33 +0200, Vincent Guittot wrote:
> >
> > Also the load balance decisions have been consolidated in the 3
> > functions
> > below after removing the few bypasses and hacks of the current code:
> > - update_sd_pick_busiest() select the busiest sched_group.
> > - find_busiest_group() checks if there is an imbalance between local
> > and
> > busiest group.
> > - calculate_imbalance() decides what have to be moved.
>
> I really like the direction this series is going.

Thanks

>
> However, I suppose I should run these patches for
> a few days with some of our test workloads before
> I send out an ack for this patch :)

Yes more tests on different platform are welcome

>
> --
> All Rights Reversed.