Re: [PATCH 1/3] ARM: dts: add Netronix E60K02 board common file

From: Andreas Kemnade
Date: Mon Sep 30 2019 - 07:02:41 EST


On Mon, 30 Sep 2019 10:27:15 +0200
Marco Felsch <m.felsch@xxxxxxxxxxxxxx> wrote:

[..]
> > so you disagree with this pattern:
> > in .dtsi
> > some_device {
> > pinctrl-0 = <&pinctrl_some_device>;
> > };
> >
> > and in .dts (one I sent with this patch series and the tolino/mx6sl one
> > is not ready-cooked yet, will be part of a later series)
> > &iomuxc {
> > pinctrl_some_device: some_devicegrp {
> > fsl,pins = <...>;
> > };
> > };
> >
> > ?
>
> Yes, because IMHO a dtsi is self contained as well as a dts. If it is
> common for all boards you can move the muxing into the dtsi else it
> should be done within the dts.
>
well, since imx6sll-pinfunc.h is different than imx6sl-pinfunc.h,
we agree that this belongs to the dts.

> > > > +&snvs_rtc {
> > > > + status = "disabled";
> > >
> > > Same applies here.
> > >
> >
> > No, seems to be an exception, it does not have a status = "disabled" in
> > imx6sll.dtsi.
>
> Did you mean 6sll or 6ull?
>
> Okay, is this baseboard only used with a 6ull?
>

MCIMX6V7DVN10AB and MCIMX6L8DVN10AB
So it is 6sll and 6sl (6sl support will be added in a follow-up patch
series).

I will send a v2 this evening, so we can all look at better-sorted
things.

Regards,
Andreas