Aw: Re: Re: [BUG] [PATCH v5 02/10] mfd: mt6397: extract irq related code from core driver

From: Frank Wunderlich
Date: Mon Sep 30 2019 - 16:58:45 EST


Hi,

bug is still present in 5.4-rc1

dmesg prints this line and at least switch is not inialized on bananapi-r2

mt6397 1000d000.pwrap:mt6323: unsupported chip: 0x0

regards Frank


> Gesendet: Donnerstag, 29. August 2019 um 08:24 Uhr
> Von: "Hsin-hsiung Wang" <hsin-hsiung.wang@xxxxxxxxxxxx>
> An: "Frank Wunderlich" <frank-w@xxxxxxxxxxxxxxx>, "Matthias Brugger" <matthias.bgg@xxxxxxxxx>
> Cc: linux-mediatek@xxxxxxxxxxxxxxxxxxx, "Mark Rutland" <mark.rutland@xxxxxxx>, "Alessandro Zummo" <a.zummo@xxxxxxxxxxxx>, "Alexandre Belloni" <alexandre.belloni@xxxxxxxxxxx>, srv_heupstream@xxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx>, "Sean Wang" <sean.wang@xxxxxxxxxxxx>, "Liam Girdwood" <lgirdwood@xxxxxxxxx>, "Rob Herring" <robh+dt@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "Richard Fontana" <rfontana@xxxxxxxxxx>, "Mark Brown" <broonie@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, "Renà van Dorst" <opensource@xxxxxxxxxx>, "Thomas Gleixner" <tglx@xxxxxxxxxxxxx>, "Eddie Huang" <eddie.huang@xxxxxxxxxxxx>, "Lee Jones" <lee.jones@xxxxxxxxxx>, "Kate Stewart" <kstewart@xxxxxxxxxxxxxxxxxxx>, linux-rtc@xxxxxxxxxxxxxxx
> Betreff: Re: Aw: Re: [BUG] [PATCH v5 02/10] mfd: mt6397: extract irq related code from core driver
>
> Hi Frank/Matthias,
>
> On Fri, 2019-08-23 at 19:16 +0200, Frank Wunderlich wrote:
> > > Gesendet: Freitag, 23. August 2019 um 17:42 Uhr
> > > Von: "Matthias Brugger" <matthias.bgg@xxxxxxxxx>
> >
> > > I suppose that's because 3/10 has code that should be in 2/10 and for some
> > > reason 3/10 was not pushed for linux-next inclusion. Although it has the same
> > > Acked-for-mfd-by tag.
> > >
> > > @Frank, can you test if adding 3/10 to your code base fixes the issue?
> >
> > adding part 3 [1] seems to fix the issue too
> >
> > [ 4.960051] mt6323-regulator mt6323-regulator: Chip ID = 0x2023
> >
> > thanks
> >
> > [1] https://patchwork.kernel.org/patch/11110509/
> Thanks for your comments.
> The root cause seems I didn't split the code well.
> I will fix it in the next version.
>
>