Re: [PATCH v2] fs: affs: fix a memory leak in affs_remount

From: Markus Elfring
Date: Tue Oct 01 2019 - 04:31:34 EST


> The allocated memory for new_opts is only released if pare_options fail.

Can the following wording be nicer?

The allocated memory for the buffer ânew_optsâ will be released
only if a call of the function âparse_optionsâ failed.


> The release for new_opts is added.

* How do you think about the change possibility to delete questionable
source code here?

* Would you like to complete the data processing for corresponding options
any more?


> -- fix a type in title, â

Please avoid typos also in your version comments.


> ---

I suggest to replace this second delimiter by a blank line.

Regards,
Markus