Re: [PATCH v22 05/24] x86/sgx: Add ENCLS architectural error codes

From: Jarkko Sakkinen
Date: Tue Oct 01 2019 - 16:23:31 EST


On Fri, Sep 27, 2019 at 10:20:12AM -0700, Sean Christopherson wrote:
> Please keep all error codes. For errors that inevitably occur during
> development, it's very helpful to have the complete list in the kernel
> (well, reasonably complete). I hate having to open and search through the
> SDM just to decipher a random numeric error code.

Unfortunately I choose here the otherwise because they serve no semantic
purpose. That is clutter by definition.

What I do is that when there is a new version of SDM I just print to
pages defining the error codes. I also keep manual "sdm-3d.pdf" all the
time open in Firefox.

I can understand your grief if you have a single PDF SDM but the purpose
of Linux GIT tree is not to fix your workflows :-) You can easily fix
them yourself.

/Jarkko