Re: [PATCH v3 0/3] selftests: netfilter: introduce test cases for ipvs
From: Simon Horman
Date: Wed Oct 02 2019 - 03:29:37 EST
On Wed, Oct 02, 2019 at 11:27:26AM +1000, Duncan Roe wrote:
> On Tue, Oct 01, 2019 at 09:34:13PM +0300, Julian Anastasov wrote:
> >
> > Hello,
> >
> > On Tue, 1 Oct 2019, Haishuang Yan wrote:
> >
> > > This series patch include test cases for ipvs.
> > >
> > > The test topology is who as below:
> > > +--------------------------------------------------------------+
> > > | | |
> > > | ns0 | ns1 |
> > > | ----------- | ----------- ----------- |
> > > | | veth01 | --------- | veth10 | | veth12 | |
> > > | ----------- peer ----------- ----------- |
> > > | | | | |
> > > | ----------- | | |
> > > | | br0 | |----------------- peer |--------------|
> > > | ----------- | | |
> > > | | | | |
> > > | ---------- peer ---------- ----------- |
> > > | | veth02 | --------- | veth20 | | veth12 | |
> > > | ---------- | ---------- ----------- |
> > > | | ns2 |
> > > | | |
> > > +--------------------------------------------------------------+
> > >
> > > Test results:
> > > # selftests: netfilter: ipvs.sh
> > > # Testing DR mode...
> > > # Testing NAT mode...
> > > # Testing Tunnel mode...
> > > # ipvs.sh: PASS
> > > ok 6 selftests: netfilter: ipvs.sh
> > >
> > > Haishuang Yan (3):
> > > selftests: netfilter: add ipvs test script
> > > selftests: netfilter: add ipvs nat test case
> > > selftests: netfilter: add ipvs tunnel test case
> >
> > Acked-by: Julian Anastasov <ja@xxxxxx>
> >
> > > tools/testing/selftests/netfilter/Makefile | 2 +-
> > > tools/testing/selftests/netfilter/ipvs.sh | 234 +++++++++++++++++++++++++++++
> > > 2 files changed, 235 insertions(+), 1 deletion(-)
> > > create mode 100755 tools/testing/selftests/netfilter/ipvs.sh
> >
> > Regards
> >
> > --
> > Julian Anastasov <ja@xxxxxx>
>
> I still prefer #!/bin/sh in 1/3. You never know what's in someone's environment
That would be my preference too.