Re: [PATCH v2 4/4] usb: host: xhci-tegra: Switch to use %ptT

[Thierry Reding]

On Tue, Oct 01, 2019 at 04:47:17PM +0300, Andy Shevchenko wrote:
> Use %ptT instead of open coded variant to print content of
> time64_t type in human readable format.
> 
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: Jonathan Hunter <jonathanh@xxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/usb/host/xhci-tegra.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
> index 2ff7c911fbd0..c1bf2ad1474d 100644
> --- a/drivers/usb/host/xhci-tegra.c
> +++ b/drivers/usb/host/xhci-tegra.c
> @@ -802,7 +802,6 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
>  	const struct firmware *fw;
>  	unsigned long timeout;
>  	time64_t timestamp;
> -	struct tm time;
>  	u64 address;
>  	u32 value;
>  	int err;
> @@ -907,11 +906,8 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
>  	}
>  
>  	timestamp = le32_to_cpu(header->fwimg_created_time);
> -	time64_to_tm(timestamp, 0, &time);
>  
> -	dev_info(dev, "Firmware timestamp: %ld-%02d-%02d %02d:%02d:%02d UTC\n",
> -		 time.tm_year + 1900, time.tm_mon + 1, time.tm_mday,
> -		 time.tm_hour, time.tm_min, time.tm_sec);
> +	dev_info(dev, "Firmware timestamp: %ptT UTC\n", &timestamp);

Can you please switch this to "Firmware timestamp: %ptTd %ptTt UTC\n" so
that the string stays the same? As discussed earlier there may be issues
if this string is changed. It may be unwise for someone to rely on the
exact format of this kernel log string, but why risk potentially causing
annoying changes in behaviour if we can easily avoid it?

Thierry

>  
>  	return 0;
>  }
> -- 
> 2.23.0
>

Attachment: signature.asc
Description: PGP signature