Re: [alsa-devel] [PATCH 2/2] soundwire: depend on ACPI || OF

From: Michal Suchánek
Date: Thu Oct 03 2019 - 06:16:03 EST


On Wed, Oct 02, 2019 at 11:06:14AM -0500, Pierre-Louis Bossart wrote:
> On 10/2/19 3:33 AM, Michal Suchanek wrote:
> > Now devicetree is supposrted for probing sondwire as well.
>
> typos...
>
> also it'd be simpler to squash the two patches together and add in the

Except we have kernels with one or both of the patches these patches
fix.

> commit message a mention that the s390 builds without ACPI and without OF.
Makes sense.

Thanks

Michal
>
> >
> > Fixes: a2e484585ad3 ("soundwire: core: add device tree support for slave devices")
> > Signed-off-by: Michal Suchanek <msuchanek@xxxxxxx>
> > ---
> > drivers/soundwire/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> > index c73bfbaa2659..c8c80df090d1 100644
> > --- a/drivers/soundwire/Kconfig
> > +++ b/drivers/soundwire/Kconfig
> > @@ -5,7 +5,7 @@
> > menuconfig SOUNDWIRE
> > tristate "SoundWire support"
> > - depends on ACPI
> > + depends on ACPI || OF
> > help
> > SoundWire is a 2-Pin interface with data and clock line ratified
> > by the MIPI Alliance. SoundWire is used for transporting data
> >
>