Re: [PATCH] mm/page_alloc: Add a reason for reserved pages in has_unmovable_pages()

From: Qian Cai
Date: Thu Oct 03 2019 - 07:50:36 EST




> On Oct 3, 2019, at 7:31 AM, Anshuman Khandual <Anshuman.Khandual@xxxxxxx> wrote:
>
> Ohh, never meant that the 'Reserved' bit is anything special here but it
> is a reason to make a page unmovable unlike many other flags.

But dump_page() is used everywhere, and it is better to reserve âreasonâ to indicate something more important rather than duplicating the page flags.

Especially, it is trivial enough right now for developers look in the page flags dumping from has_unmovable_pages(), and figure out the exact branching in the code.