Re: [REPOST][RFC][PATCH] sysctl: Remove the sysctl system call

From: Kees Cook
Date: Thu Oct 03 2019 - 17:05:29 EST


On Thu, Oct 03, 2019 at 03:44:32PM -0500, Eric W. Biederman wrote:
>
> This system call has been deprecated almost since it was introduced, and none
> of the common distributions enable it. The only indication that I can find that
> anyone might care is that a few of the defconfigs in the kernel enable it. However
> that is a small fractions of the defconfigs so I suspect it just a lack of care
> rather than a reflection of software using the the sysctl system call.
>
> As there appear to be no users of the sysctl system call, remove the
> code so that the proc filesystem can be simplified.

nitpick: line lengths near 80 characters

> Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

But, yes, I would love to see this gone. :)

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook