Re: [PATCH] rsi: fix potential null dereference in rsi_probe()

[Kalle Valo]

Johan Hovold <johan@xxxxxxxxxx> writes:

> On Fri, Oct 04, 2019 at 01:47:36PM +0000, Kalle Valo wrote:
>> Denis Efremov <efremov@xxxxxxxxx> wrote:
>> 
>> > The id pointer can be NULL in rsi_probe().
>
> While the existing code in rsi_probe() may lead you to believe that,
> this statement is false. 
>
>> > It is checked everywhere except
>> > for the else branch in the idProduct condition. The patch adds NULL check
>> > before the id dereference in the rsi_dbg() call.
>> > 
>> > Fixes: 54fdb318c111 ("rsi: add new device model for 9116")
>> > Cc: Amitkumar Karwar <amitkarwar@xxxxxxxxx>
>> > Cc: Siva Rebbagondla <siva8118@xxxxxxxxx>
>> > Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
>> > Signed-off-by: Denis Efremov <efremov@xxxxxxxxx>
>> 
>> Patch applied to wireless-drivers-next.git, thanks.
>> 
>> f170d44bc4ec rsi: fix potential null dereference in rsi_probe()
>
> I just sent a revert to prevent the confusion from spreading (e.g. to
> stable autosel and contributers looking for things to work on). Hope you
> don't mind, Kalle.

That's great, thanks Johan.

-- 
Kalle Valo