Re: [PATCH 2/3] watchdog: sam9x60_wdt: introduce sam9x60 watchdog timer driver

From: Guenter Roeck
Date: Mon Oct 07 2019 - 08:36:43 EST


On 10/7/19 12:58 AM, Eugen.Hristev@xxxxxxxxxxxxx wrote:
[ ... ]
Hello Guenter,

Thank you for the feedback.
After reviewing this, can you please guide me towards one of the
possible two directions: merge this driver with sama5d4_wdt , and have a
single driver with support for both hardware blocks; or, have this
driver separately , as in this patch series?


I noticed the similarities. I don't know if it makes sense to reconcile
the two drivers; it seems to me the new chip uses the same basic core with
enhancements. In general, I prefer a single driver, but only if the result
doesn't end up being an if/else mess. Ultimately, it is really your call
to make.

Guenter