Re: [PATCH 1/1] iio: (bma400) add driver for the BMA400

From: Dan Robertson
Date: Tue Oct 08 2019 - 10:44:15 EST


Thanks for the review! I _think_ I've made all the changes you mentioned
locally. I'll run some more tests and clean it up a bit before submitting the
next patchset version.

> So my first thought was that Bosch have been moderately good at keeping their
> interfaces consistent across generations. Seems not this time from
> a quick look!

Originally I had hoped to extend the bma180 driver, but there did seem to be a
reasonably large change in the interfaces. I also hope to add support for some
of the newer features and SPI. I think it would be possible to merge the two
drivers, but I think it would require pretty close to a complete overhaul of
the bma180 driver. If this is something you'd like to explore, I can probably
order a breakout board for the BMA180 and BMA220 and work on a way to create a
driver that supports all three.

> I'd also expect a modern driver to have DT bindings. Might let that go if
> it was being used with ACPI but neither is true here.

Good catch. The DT bindings will be very simple in the initial version of the
driver. I'll add the bindings and some documentation.

> See the docs for struct iio_info -> read_avail.

Nice! I missed this. This fits exactly what I needed.



Attachment: signature.asc
Description: Digital signature