Re: [PATCH] ARM: dts: am335x-sancloud-bbe: Fix PHY mode for ethernet

From: Jeroen Hofstee
Date: Tue Oct 08 2019 - 12:59:37 EST


On 10/8/19 6:51 PM, Tony Lindgren wrote:
> * Jeroen Hofstee <jhofstee@xxxxxxxxxxxxxxxxx> [191008 16:43]:
>> Hello Tony,
>> On 10/8/19 6:14 PM, Tony Lindgren wrote:
>>> * Jeroen Hofstee <jhofstee@xxxxxxxxxxxxxxxxx> [191008 16:03]:
>>>> Hello Tony,
>>>> On 10/8/19 4:23 PM, Tony Lindgren wrote:
>>>>> * Grygorii Strashko <grygorii.strashko@xxxxxx> [191003 02:32]:
>>>>>> On 03/10/2019 11:16, Jeroen Hofstee wrote:
>>>>>>> Furthermore 4.19 is fine, so there is no need to include it in stable
>>>>>>> and have a note to make sure also other patches are required etc.
>>>>>> Hence all above patches went in 5.1 it would be correct to mention only
>>>>>> 6d4cd041f0af net: phy: at803x: disable delay only for RGMII mode
>>>>> Jeroen, can you please send an updated patch with the fixes
>>>>> tag changed?
>>>> For completeness, there is no "Fixes tag" as you mentioned.
>>>> The commit only refers to another commit which introduces
>>>> a problem.
>>> Well please add the fixes tag, that way this will get
>>> properly applied to earlier stable kernels too :)
>> But 4.19 is fine, this is an issue in 5.1 as in EOL...
>> I really don't understand why I should waste time
>> to figure out what happened exactly during the 5.1
>> release cycle...
> Hmm so what's the issue with just adding the fixes tag Grygorii
> suggested:
> 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
> No need to dig further?

Grygorii doesn't suggest to add a fixes tag, just to change the referenced
commit to another. Obviously I would like to understand why another commit
should be referenced. And then I should read and parse the response, so there
is no special reason, just time...