Re: [PATCH 4.19 001/106] tpm: use tpm_try_get_ops() in tpm-sysfs.c.

From: Jarkko Sakkinen
Date: Tue Oct 08 2019 - 19:45:22 EST


On Tue, Oct 08, 2019 at 02:51:20PM +0200, Pavel Machek wrote:
> For example this did not have any locking, and is now protected by
>
> get_device(&chip->dev);
>
> down_read(&chip->ops_sem);
>
> . Is that intended? Is this known to fix any bugs?

It is, sysfs code can otherwise race when ops is set NULL in
class shutdown.

/Jarkko