Re: [PATCH 2/3] dt-bindings: net: ftgmac100: Describe clock properties
From: Andrew Jeffery
Date: Tue Oct 08 2019 - 20:18:55 EST
On Tue, 8 Oct 2019, at 23:12, Joel Stanley wrote:
> On Tue, 8 Oct 2019 at 11:50, Andrew Jeffery <andrew@xxxxxxxx> wrote:
> > Critically, the AST2600 requires ungating the RMII RCLK if e.g. NCSI is
> > in use.
> > Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/net/ftgmac100.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
> > diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt b/Documentation/devicetree/bindings/net/ftgmac100.txt
> > index 04cc0191b7dd..c443b0b84be5 100644
> > --- a/Documentation/devicetree/bindings/net/ftgmac100.txt
> > +++ b/Documentation/devicetree/bindings/net/ftgmac100.txt
> > @@ -24,6 +24,12 @@ Optional properties:
> > - no-hw-checksum: Used to disable HW checksum support. Here for backward
> > compatibility as the driver now should have correct defaults based on
> > the SoC.
> > +- clocks: In accordance with the generic clock bindings. Must describe the MAC
> > + IP clock, and optionally an RMII RCLK gate for the AST2600.
> or AST2500.
> With that fixed you can add my ack.
I'll do a v2 and fix the comments in the driver patch as well.