Re: [PATCH 19/20] dpaa_eth: add dpaa_dma_to_virt()

From: Laurentiu Tudor
Date: Wed Oct 09 2019 - 06:06:17 EST


On 09.10.2019 10:39, Christoph Hellwig wrote:
> On Tue, Oct 08, 2019 at 03:10:40PM +0300, Madalin Bucur wrote:
>> Centralize the phys_to_virt() calls.
>
> You don't need to centralize those, you need to fix them. Calling
> phys_to_virt on a dma_addr is completely bogus.
>

Yeah, that's on my TODO list [1] for quite a while, among others. I'll
return to it as soon as I'm done with the burning stuff I'm currently on.

[1] https://patchwork.kernel.org/patch/10968947/

---
Best Regards, Laurentiu