Re: [PATCH RFC v2 2/2] dmaengine: avalon: Intel Avalon-MM DMA Interface for PCIe test

From: Greg KH
Date: Wed Oct 09 2019 - 09:08:24 EST


On Wed, Oct 09, 2019 at 12:12:31PM +0200, Alexander Gordeev wrote:
> +config AVALON_TEST_TARGET_BASE
> + hex "Target device base address"
> + default "0x70000000"
> +
> +config AVALON_TEST_TARGET_SIZE
> + hex "Target device memory size"
> + default "0x10000000"

Don't put stuff like this as a configuration option, requiring the
kernel to be rebuilt. Make it dynamic, or from device tree, but not
like this.

thanks,

greg k-h