Re: [RFC v2 0/1] s390/purgatory: Make sure we fail the build if purgatory has missing symbols
From: Christian Borntraeger
Date: Wed Oct 09 2019 - 10:50:31 EST
On 09.10.19 11:39, Philipp Rudo wrote:
> Hi Hans,
> also adding Ingo on Cc.
> I tested you patch on s390 and it does what it's supposed to do. The build now
> fails with
> LD arch/s390/purgatory/purgatory.chk
> arch/s390/purgatory/purgatory: In function `sha256_update':
> (.text+0x3bc2): undefined reference to `memzero_explicit'
> /home/prudo/git/linux/linux/arch/s390/purgatory/Makefile:38: recipe for target 'arch/s390/purgatory/purgatory.chk' failed
> make: *** [arch/s390/purgatory/purgatory.chk] Error 1
> After applying Arvid's memzero_explizit fix ("[PATCH] lib/string: make
> memzero_explicit inline instead of external") as well the build works again.
> My only problem is how to uptream your patch. Just adding it to our branch
> would cause a (intentional) build breakage until Ingo's branch is merged.
> @Vasliy & Ingo: Can you please find a solution for this.
I talked quickly to Vasily. The best solution is likely to carry that
patch in the tree that contains the fix. Ingo, can you carry the s390
patch in your tip tree as well?
With my s390 co-maintainer hat on:
Acked-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
Please also consider Philipps mail as "Tested-by:"