Re: [PATCH 6/6] x86/fpu/xstate: Rename validate_xstate_header() to validate_xstate_header_from_user()

From: Borislav Petkov
Date: Wed Oct 09 2019 - 13:32:08 EST


On Wed, Sep 25, 2019 at 08:10:22AM -0700, Yu-cheng Yu wrote:
> From: Fenghua Yu <fenghua.yu@xxxxxxxxx>
>
> The function validate_xstate_header() validates an xstate header coming
> from userspace (PTRACE or sigreturn). To make it clear, rename it to
> validate_xstate_header_from_user().
>
> Suggested-by: Dave Hansen <dave.hansen@xxxxxxxxx>
> Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> Signed-off-by: Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx>

This one is correct!

\o/

> Reviewed-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>
> ---
> arch/x86/include/asm/fpu/xstate.h | 2 +-
> arch/x86/kernel/fpu/regset.c | 2 +-
> arch/x86/kernel/fpu/signal.c | 2 +-
> arch/x86/kernel/fpu/xstate.c | 6 +++---
> 4 files changed, 6 insertions(+), 6 deletions(-)

And I like patches like this one! :-)

Reviewed-by: Borislav Petkov <bp@xxxxxxx>

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette