Re: [PATCH 4/4] riscv: remove the switch statement in do_trap_break()

From: Paul Walmsley
Date: Wed Oct 09 2019 - 18:26:12 EST


On Mon, 7 Oct 2019, Christoph Hellwig wrote:

> On Mon, Oct 07, 2019 at 09:08:23AM -0700, Paul Walmsley wrote:
> > force_sig_fault(SIGTRAP, TRAP_BRKPT,
> > (void __user *)(regs->sepc));
>
> No nee for the extra braces, which also means it all fits onto a single
> line. You could have just copied what I pasted..

It turns out that the rewrite breaks allnoconfig:

https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx/thread/VDCU2WOB6KQISREO4V5DTXEI2M7VOV55/

Am just going to pick up Vincent's original patch. Then we can do
any subsequent cleanup in a separate patch.


- Paul