Re: [PATCH] ACPI: PM: Revert "ACPI / PM: Blacklist Low Power S0 Idle _DSM for Dell XPS13 9360"
From: Rafael J. Wysocki
Date: Thu Oct 10 2019 - 04:53:24 EST
On Tue, Oct 8, 2019 at 3:44 AM <Mario.Limonciello@xxxxxxxx> wrote:
> > On 26.09.19 18:08, Mario Limonciello wrote:
> > > This reverts part of
> > > commit 71630b7a832f ("ACPI / PM: Blacklist Low Power S0 Idle _DSM for
> > > Dell XPS13 9360") to remove the S0ix blacklist for the XPS 9360.
> > >
> > > The problems with this system occurred in one possible NVME SSD when
> > > putting system into s0ix. As the NVME sleep behavior has been
> > > adjusted in d916b1be this is expected to be now resolved.
> > 1. Please add, that it was the Hynix(?) SSD.
> > 2. Please add the commit message summary of d916b1be.
> > nvme-pci: use host managed power state for suspend
> Rafael, let me know if you want me to adjust the commit message and resubmit
> or if you would just handle this task.
> > > Cc: 'Paul Menzel <pmenzel@xxxxxxxxxxxxx>'
> > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=196907
> > > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxxx>
> > Tag it for the stable series? d916b1be (first tag v5.3-rc1) is not tagged for stable.
> Although Dell arranged a lot of testing with partners I don't feel d916b1be is a stable
> candidate. Rafael found a corner case with regards to ASPM configuration last minute
> in 5.3rcX, I found a another corner case related to order of events and timing around
> PC10 entry that's getting fixed in 5.4.
> > > ---
> > > The particular failing configuration was reported by only ever failed
> > > for Paul Menzel, so hopefully he can test on his failing system.
> > I successfully tested Linux 5.4-rc1+ with this commit last Friday on the Dell XPS
> > 13 9360.
> > Tested-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
> Well that's great, appreciate your testing and confirmation.