Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

From: Felipe Balbi
Date: Thu Oct 10 2019 - 06:17:20 EST


Roger Quadros <rogerq@xxxxxx> writes:
>>> Peter Chen <peter.chen@xxxxxxx> writes:
>>>> On 19-10-07 07:39:11, Pawel Laszczak wrote:
>>>>> Patch fixes issue with Halt Endnpoint Test observed
>>>> %s/Endnpoint/Endpoint
>>>>> during using g_zero
>>>>> driver as DUT. Bug occurred only on some testing board.
>>>> g_zero is legacy, please use configfs function source_sink or loopback
>>>> instead.
>>> We still want fixes for those ;-)
>> So, if my understanding is correct in new production systems
>> using legacy gadget drivers is not recommended and we are not going to fix
>> any more bugs there.
> We can't really control who uses what. So we need to support legacy
> drivers as well.
> The issue detected by using g_zero is a controller driver issue and not an
> issue with g_zero itself.

thanks for clarifying, Roger.

Pawel, Roger is correct here. But in any case, if *real* bugs are found
on the legacy gadget drivers, let's see if they happen with
configfs-based interface as well. They should behave exactly the same
nowadays since legacy driver were converted to simply programmatically
spawn the configfs interface.

If there are bugs in legacy gadget drivers, we *WANT* to fix those.