Re: [PATCH v2] xen: Stop abusing DT of_dma_configure API

From: Boris Ostrovsky
Date: Thu Oct 10 2019 - 11:44:52 EST

On 10/10/19 11:32 AM, Rob Herring wrote:
> On Thu, Oct 10, 2019 at 9:00 AM Boris Ostrovsky
> <boris.ostrovsky@xxxxxxxxxx> wrote:
>> On 10/9/19 7:42 AM, Oleksandr Andrushchenko wrote:
>>> On 10/8/19 10:41 PM, Rob Herring wrote:
>>>> As the removed comments say, these aren't DT based devices.
>>>> of_dma_configure() is going to stop allowing a NULL DT node and calling
>>>> it will no longer work.
>>>> The comment is also now out of date as of commit 9ab91e7c5c51 ("arm64:
>>>> default to the direct mapping in get_arch_dma_ops"). Direct mapping
>>>> is now the default rather than dma_dummy_ops.
>>>> According to Stefano and Oleksandr, the only other part needed is
>>>> setting the DMA masks and there's no reason to restrict the masks to
>>>> 32-bits. So set the masks to 64 bits.
>>>> Cc: Robin Murphy <robin.murphy@xxxxxxx>
>>>> Cc: Julien Grall <julien.grall@xxxxxxx>
>>>> Cc: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>
>>>> Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>>> Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>>>> Cc: Juergen Gross <jgross@xxxxxxxx>
>>>> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>>>> Cc: Christoph Hellwig <hch@xxxxxx>
>>>> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
>>>> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>>> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>> Is this going to go via drm tree or should I pick it up for Xen tree?
> Please apply to the Xen tree.

Ok. FTR,

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>