Re: [PATCH v3 8/8] dt-bindings: Add max12xx SPI ADC series as trivial devices
From: Rob Herring
Date: Thu Oct 10 2019 - 16:47:55 EST
On Mon, Oct 07, 2019 at 03:26:57PM +0200, Miquel Raynal wrote:
> Update the compatible list with three Maxim ADCs compatibles.
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> .../bindings/iio/adc/max1027-adc.txt | 28 +++++++++++++++++++
> .../devicetree/bindings/trivial-devices.yaml | 6 ++++
> 2 files changed, 34 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/max1027-adc.txt
Devices are supposed to be documented in one place or the other. So
either make max1027-adc.txt a schema or drop it.
I'm fine either way. Obviously, trivial-devices.yaml is trivial to add
to, but it does leave some ambiguities. Like is an interrupt required,
optional or non-existent? What about power supplies? Or what are allowed
values for spi-max-frequency.