Re: [PATCH 4/4] scripts/cvt_style.pl: Tool to reformat sources in various ways
From: Joe Perches
Date: Thu Oct 10 2019 - 16:48:44 EST
On Thu, 2019-10-10 at 13:39 -0700, Kees Cook wrote:
> On Sat, Oct 05, 2019 at 11:35:42PM -0700, Joe Perches wrote:
> > I think clang-format could not do this sort of conversion.
> > Nor could coccinelle or checkpatch.
> > Anyway, it's not really necessary for this particular patch
> > to be applied, but it's a convenient way to show the script
> > has the capability to do fallthrough comment conversions.
> > I think it does conversions fairly reasonably but likely
> > some files could not compile without adding an #include
> > like:
> > #include <linux/compiler.h>
> I think this is a nice tool to add -- at the very least it serves as
> infrastructure for future similar conversions. And small cleanups can be
> generated from it for people looking to clean up subsystems, etc.
Another similar tool that used checkpatch and also compile
tested and created git commits was reformat_with_checkpatch