Re: [PATCH 1/2] net: fec_main: Use platform_get_irq_byname_optional() to avoid error message

From: Jakub Kicinski
Date: Thu Oct 10 2019 - 19:08:29 EST

On Wed, 9 Oct 2019 18:15:47 +0800, Anson Huang wrote:
> Failed to get irq using name is NOT fatal as driver will use index
> to get irq instead, use platform_get_irq_byname_optional() instead
> of platform_get_irq_byname() to avoid below error message during
> probe:
> [ 0.819312] fec 30be0000.ethernet: IRQ int0 not found
> [ 0.824433] fec 30be0000.ethernet: IRQ int1 not found
> [ 0.829539] fec 30be0000.ethernet: IRQ int2 not found
> Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()")
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>

Hi Anson,

looks like there may be some dependency which haven't landed in the
networking tree yet? Because this doesn't build:

drivers/net/ethernet/freescale/fec_main.c: In function âfec_probeâ:
drivers/net/ethernet/freescale/fec_main.c:3561:9: error: implicit declaration of function âplatform_get_irq_byname_optionalâ; did you mean âplatform_get_irq_optionalâ? [-Werror=implicit-function-declaration]
3561 | irq = platform_get_irq_byname_optional(pdev, irq_name);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| platform_get_irq_optional
cc1: some warnings being treated as errors

Could you please repost once that's resolved? Please add Andy's and
Stephen's acks when reposting.

Thank you!