Re: [PATCH] staging: sm750fb: Potential uninitialized field in "pll"
From: Yizhuo Zhai
Date: Thu Oct 10 2019 - 20:37:25 EST
Sorry about that, let me resend it .
On Thu, Oct 10, 2019 at 2:53 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Wed, Oct 09, 2019 at 09:38:08PM -0700, Yizhuo wrote:
> > Inside function set_chip_clock(), struct pll is supposed to be
> > initialized in sm750_calc_pll_value(), if condition
> > "diff < mini_diff" in sm750_calc_pll_value() cannot be fulfilled,
> > then some field of pll will not be initialized but used in
> > function sm750_format_pll_reg(), which is potentially unsafe.
> > Signed-off-by: Yizhuo <yzhai003@xxxxxxx>
> The patch is correct, but it doesn't apply to linux-next any more. Can
> you re-write it on top of the most recent staging-next and resend?
> dan carpenter
Computer Science, Graduate Student
University of California, Riverside