Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
From: Linus Walleij
Date: Fri Oct 11 2019 - 03:27:11 EST
On Mon, Oct 7, 2019 at 10:14 AM Marc Zyngier <maz@xxxxxxxxxx> wrote:
> On Mon, 07 Oct 2019 08:30:50 +0100,
> Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > Hi Chris,
> > CC MarcZ
> > On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
> > <chris.packham@xxxxxxxxxxxxxxxxxxx> wrote:
> > > Use the dev_name(dev) for the irqc->name so that we get unique names
> > > when we have multiple instances of this driver.
> > >
> > > Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
> > A while ago, Marc Zyngier pointed out that the irq_chip .name field
> > should contain the device's class name, not the instance's name.
> > Hence the current code is correct?
> Thanks Geert for looping me in. The main reasons why I oppose this
> kind of "let's show as much information as we can in /proc/interrupts"
> - It clutters the output badly: the formatting of this file, which is
> bad enough when you have a small number of CPUs, becomes unreadable
> when you have a large number of them *and* stupidly long strings
> that only make sense on a given platform.
> - Like it or not, /proc is ABI. We don't change things randomly there
> without a good reason, and debugging isn't one of them.
> - Debug information belongs to debugfs, where we already have plenty
> of stuff (see CONFIG_GENERIC_IRQ_DEBUGFS). I'd rather we improve
> this infrastructure if needed, rather than add platform specific
I have reverted the patch.