Re: [PATCH] staging: wfx: fix potential vulnerability to spectre
From: Dan Carpenter
Date: Fri Oct 11 2019 - 08:55:04 EST
On Fri, Oct 11, 2019 at 12:35:36PM +0000, Jerome Pouiller wrote:
> On Friday 11 October 2019 14:10:35 CEST Greg Kroah-Hartman wrote:
> > On Fri, Oct 11, 2019 at 10:15:54AM +0000, Jerome Pouiller wrote:
> > > From: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>
> > >
> > > array_index_nospec() should be applied after a bound check.
> > >
> > > Fixes: 9bca45f3d6924f19f29c0d019e961af3f41bdc9e ("staging: wfx: allow to send 802.11 frames")
> > No need for the full sha1, this should be:
> > Fixes: 9bca45f3d692 ("staging: wfx: allow to send 802.11 frames")
> I copy-pasted information from kbuild robot notification.
> I suggest that commit-id in robot notification is also cut down to 12
> characters. Or even better, to use this snippet:
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Fixes: 9bca45f3d692 ("staging: wfx: allow to send 802.11 frames")
> (I added lkp@xxxxxxxxxxxx in CC but, I am not sure it is the correct
> ML. I am sorry if it is not the case)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing
commit: 9bca45f3d6924f19f29c0d019e961af3f41bdc9e [55/111] staging: wfx: allow to send 802.11 frames
If you cut and paste then you the "[55/111] " text isn't right either.
Also kbuild works on rebase-able trees as well as non-rebase/published
trees so the hash could change as well.
I am a little bit surprised that checkpatch.pl doesn't complain about
this, though. You could consider adding that?