Re: [PATCH net] rxrpc: Fix possible NULL pointer access in ICMP handling

From: Eric Dumazet
Date: Sat Oct 12 2019 - 07:06:17 EST




On 10/12/19 3:49 AM, Eric Dumazet wrote:

>
> Okay, but we also need this.
>
> diff --git a/net/rxrpc/peer_event.c b/net/rxrpc/peer_event.c
> index c97ebdc043e44525eaecdd54bc447c1895bdca74..38db10e61f7a5cb50f9ee036b5e16ec284e723ac 100644
> --- a/net/rxrpc/peer_event.c
> +++ b/net/rxrpc/peer_event.c
> @@ -145,9 +145,9 @@ static void rxrpc_adjust_mtu(struct rxrpc_peer *peer, struct sock_exterr_skb *se
> */
> void rxrpc_error_report(struct sock *sk)
> {
> + struct rxrpc_local *local = rcu_dereference_sk_user_data(sk);
> struct sock_exterr_skb *serr;
> struct sockaddr_rxrpc srx;
> - struct rxrpc_local *local = sk->sk_user_data;
> struct rxrpc_peer *peer;
> struct sk_buff *skb;
>

I will psubmit the patch later once David pushes his net tree, since I do not know yet
the sha1 of your patch (to provide a proper Fixes: tag)