tcp: Checking a kmemdup() call in tcp_time_wait()

From: Markus Elfring
Date: Sat Oct 12 2019 - 10:52:31 EST


Hello,

I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function âtcp_time_waitâ contains also a call of the function âkmemdupâ.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/ipv4/tcp_minisocks.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n306
https://elixir.bootlin.com/linux/v5.4-rc2/source/net/ipv4/tcp_minisocks.c#L306

* Do you find the usage of the macro call âBUG_ONâ still appropriate at this place?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n4080

* Is there a need to adjust the error handling here?

Regards,
Markus