Re: net: tulip: de2104x: Checking a kmemdup() call in de21041_get_srom_info()

From: Sven Schnelle
Date: Sat Oct 12 2019 - 13:21:04 EST

On Sat, Oct 12, 2019 at 07:03:09PM +0200, Markus Elfring wrote:
> Hello,
> I tried another script for the semantic patch language out.
> This source code analysis approach points out that the implementation
> of the function âde21041_get_srom_infoâ contains still an unchecked call
> of the function âkmemdupâ.
> How do you think about to improve it?

If i have not missed a place, the only user is de_get_eeprom(), which checks
whether de->ee_data is valid. So i think although not obvious, there's no
problem here.