Re: [for-linus][PATCH 08/11] recordmcount: Fix nop_mcount() function

From: Uwe Kleine-König
Date: Sun Oct 13 2019 - 15:14:13 EST


On Sun, Oct 13, 2019 at 02:57:43PM -0400, Steven Rostedt wrote:
> One problem with quilt, is that it doesn't like non-ASCII characters
> (I'm looking at you Kleine-König!)
>
> From: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx>
>
> The removal of the longjmp code in recordmcount.c mistakenly made the
> return of make_nop() being negative an exit of nop_mcount(). It should
> not exit the routine, but instead just not process that part of the
> code. By exiting with an error code, it would cause the update of
> recordmcount to fail some files which would fail the build if ftrace
> function tracing was enabled.
>
> Link: http://lkml.kernel.org/r/20191009110538.5909fec6@xxxxxxxxxxxxxxxxxx
>
> Reported-by: Uwe Kleine-önig <u.kleine-koenig@xxxxxxxxxxxxxx>
> Tested-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

And now it seems to have problems with plain ASCII-K, but only once out
of two :-|

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |