Re: [PATCH 2/7] Add a concept of a "secure" anonymous file

From: kbuild test robot
Date: Sun Oct 13 2019 - 23:02:17 EST


Hi Daniel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.4-rc2 next-20191011]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Daniel-Colascione/Harden-userfaultfd/20191014-102741
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

fs/anon_inodes.c: In function 'anon_inode_make_secure_inode':
>> fs/anon_inodes.c:67:10: error: implicit declaration of function 'security_inode_init_security_anon'; did you mean 'security_inode_init_security'? [-Werror=implicit-function-declaration]
error = security_inode_init_security_anon(inode, name, fops);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
security_inode_init_security
cc1: some warnings being treated as errors

vim +67 fs/anon_inodes.c

57
58 struct inode *anon_inode_make_secure_inode(const char *name,
59 const struct file_operations *fops)
60 {
61 struct inode *inode;
62 int error;
63 inode = alloc_anon_inode(anon_inode_mnt->mnt_sb);
64 if (IS_ERR(inode))
65 return ERR_PTR(PTR_ERR(inode));
66 inode->i_flags &= ~S_PRIVATE;
> 67 error = security_inode_init_security_anon(inode, name, fops);
68 if (error) {
69 iput(inode);
70 return ERR_PTR(error);
71 }
72 return inode;
73 }
74

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip