RE: [EXT] Re: [v2,2/2] dt-bindings: i2c-mux-pca954x: Add optional property i2c-mux-never-disable
From: Biwen Li
Date: Mon Oct 14 2019 - 00:17:29 EST
> > On Mon, Sep 30, 2019 at 11:25:03AM +0800, Biwen Li wrote:
> > > The patch adds an optional property i2c-mux-never-disable
> > >
> > > Signed-off-by: Biwen Li <biwen.li@xxxxxxx>
> > > ---
> > > Change in v2:
> > > - update documentation
> > >
> > > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> > > b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> > > index 30ac6a60f041..71b73d0fdb62 100644
> > > --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> > > +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> > > @@ -34,6 +34,7 @@ Optional Properties:
> > > - first cell is the pin number
> > > - second cell is used to specify flags.
> > > See also
> > > Documentation/devicetree/bindings/interrupt-controller/interrupts.tx
> > > t
> > > + - i2c-mux-never-disable: always forces mux to be enabled.
> > Either needs to have a vendor prefix or be documented as a common
> > property.
I choose to be documented as a common property.
> > IIRC, we already have a property for mux default state which seems
> > like that would cover this unless you need to leave it in different states.
> Okay, you are right, thank you so much. I will try it in v3.
Do you mean that the property is i2c-mux-idle-disconnect in Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt?
If so, the property i2c-mux-idle-disconnect is not good for me.
Because condition of the property i2c-mux-idle-disconnect is in idle state(sometimes).
But I need always enable i2c multiplexer in whatever state(anytime), so I add a common property i2c-mux-never-disable.
> > Rob