RE: [EXT] Re: [v2 2/2] arm64: dts: ls1028a: Update the DT node definition for dpclk

From: Wen He
Date: Mon Oct 14 2019 - 02:26:28 EST




> -----Original Message-----
> From: Shawn Guo <shawnguo@xxxxxxxxxx>
> Sent: 2019å10æ14æ 14:22
> To: Wen He <wen.he_1@xxxxxxx>
> Cc: linux-devel@xxxxxxxxxxxxxxxxxx; Leo Li <leoyang.li@xxxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [EXT] Re: [v2 2/2] arm64: dts: ls1028a: Update the DT node
> definition for dpclk
>
> Caution: EXT Email
>
> On Tue, Oct 08, 2019 at 04:08:57AM +0000, Wen He wrote:
> >
> >
> > > -----Original Message-----
> > > From: Shawn Guo <shawnguo@xxxxxxxxxx>
> > > Sent: 2019å10æ7æ 20:35
> > > To: Wen He <wen.he_1@xxxxxxx>
> > > Cc: linux-devel@xxxxxxxxxxxxxxxxxx; Leo Li <leoyang.li@xxxxxxx>; Rob
> > > Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>;
> > > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > > Subject: [EXT] Re: [v2 2/2] arm64: dts: ls1028a: Update the DT node
> > > definition for dpclk
> > >
> > >
> > > On Fri, Sep 20, 2019 at 04:34:19PM +0800, Wen He wrote:
> > > > Update DT node name clock-controller to clock-display,
> > >
> > > The node name clock-controller is so good, and I do not understand
> > > why you need to change it.
> > >
> >
> > The node name clock-controller used for the system clockgen and this
> > clock only used for the Display core.
> > To clearly the node, that why I have to use clock-display to instead
> > of the clock-controller
>
> Label is being used to specify things, and node name should just be as generic
> as possible.

Understand, will correction it.

Thanks && Best Regards,
Wen

>
> Shawn