Re: [PATCH] tick: check if broadcast device could really be stopped
From: Thomas Gleixner
Date: Mon Oct 14 2019 - 08:56:41 EST
On Wed, 9 Oct 2019, Benjamin Gaignard wrote:
> @@ -78,7 +78,7 @@ static bool tick_check_broadcast_device(struct clock_event_device *curdev,
> if ((newdev->features & CLOCK_EVT_FEAT_DUMMY) ||
> (newdev->features & CLOCK_EVT_FEAT_PERCPU) ||
> - (newdev->features & CLOCK_EVT_FEAT_C3STOP))
> + tick_broadcast_could_stop(newdev))
No. This might be called _before_ a cpuidle driver is available and then
when that driver is loaded and goes deep, everything goes south.
Aside of that it definitely breaks everything which does not use the
cpuidle stuff, which includes all machines affected by X86_BUG_AMD_APIC_C1E
and everything which uses the INTEL_IDLE driver.
Pretty much the same problem for all other places you changed.