Re: [PATCH 1/2] dt-bindings: i2c: replace property i2c-mux-idle-disconnect
From: Peter Rosin
Date: Mon Oct 14 2019 - 11:45:01 EST
On 2019-10-14 13:25, Biwen Li wrote:
> This replaces property i2c-mux-idle-disconnect with idle-state
> Signed-off-by: Biwen Li <biwen.li@xxxxxxx>
> Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> index 30ac6a60f041..f2db517b1635 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> @@ -25,9 +25,7 @@ Required Properties:
> Optional Properties:
> - reset-gpios: Reference to the GPIO connected to the reset input.
> - - i2c-mux-idle-disconnect: Boolean; if defined, forces mux to disconnect all
> - children in idle state. This is necessary for example, if there are several
> - multiplexers on the bus and the devices behind them use same I2C addresses.
> + - idle-state: Please refer to Documentation/devicetree/bindings/mux/mux-controller.txt
> - interrupts: Interrupt mapping for IRQ.
> - interrupt-controller: Marks the device node as an interrupt controller.
> - #interrupt-cells : Should be two.
You can't just remove i2c-mux-idle-disconnect. It needs to remain, and the
driver needs to maintain support for this in case a new kernel is running
with an old devicetree.