Re: [PATCH v4] rtc: wilco-ec: Handle reading invalid times

From: Alexandre Belloni
Date: Mon Oct 14 2019 - 11:50:27 EST


On 04/10/2019 08:26:08-0600, Nick Crews wrote:
> If the RTC HW returns an invalid time, the rtc_year_days()
> call would crash. This patch adds error logging in this
> situation, and removes the tm_yday and tm_wday calculations.
> These fields should not be relied upon by userspace
> according to man rtc, and thus we don't need to calculate
> them.
>
> Signed-off-by: Nick Crews <ncrews@xxxxxxxxxxxx>
> ---
> drivers/rtc/rtc-wilco-ec.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com